[m-rev.] For review: automatically update copyright messages

[Ralph Becket]

Fergus Henderson, Wednesday, 13 November 2002:
> 
> Sure, but what about e.g.
> 
> 	Copyright (C) J. R. Hacker and The University of Melbourne, 2001

This will become 

 	Copyright (C) J. R. Hacker and The University of Melbourne, 2001-2002

The unfortunate case is

 	Copyright (C) 1999 J. R. Hacker and The University of Melbourne

which gets turned into

 	Copyright (C) 1999 J. R. Hacker and, 2002 The University of Melbourne

which you may or may not like!  But the diff will show this one up.
It all depends how much effort you think is worth putting into this one.

> > +		if ( query_user("Accept the version with the updated copyright message?", 1) )
> > +		{
> > +			system("mv", $tmp, $arg);
> 
> Maybe you should use `system(...) || die("...")'?

Okay.  I wasn't sure which side to err on, but since you actually have
an opinion I'll err that way!

> > +		if ( $default_yes )
> > +		{ $default_string = "[y]" }
> > +		else
> > +		{ $default_string = "[n]" }
> 
> Missing semicolons before "}"?

Odd that Perl didn't catch that one.  I'll put 'em in.

> > +		if ( $default_yes )
> > +		{ $default_string = "-default yes" }
> > +		else
> > +		{ $default_string = "-default no" }
> 
> Missing semicolons before "}"?

Ditto.

- Ralph
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------