[m-rev.] for review: debugging tabling procedures

Zoltan Somogyi zs at cs.mu.OZ.AU
Tue Nov 12 16:55:09 AEDT 2002


On 12-Nov-2002, Fergus Henderson <fjh at cs.mu.OZ.AU> wrote:
> The names MR_<type>_hash_contents() make it sound like these routines
> hash the contents of something.  I think it would be clearer to name these
> MR_<type>_hash_get_contents(), MR_<type>_get_hash_table_contents(),
> or MR_<type>_hash_table_get_contents().

Done.

> > +static MR_bool
> > +MR_trace_fill_in_int_table_arg_slot(MR_TrieNode *table_cur_ptr,
> > +	int arg_num, MR_ConstString given_arg,
> > +	MR_Call_Table_Arg *call_table_arg_ptr)
> 
> Some comments explaining what this function does (and the meaning of
> the return value) would be helpful.

Done.

> > +static MR_bool
> > +MR_update_int_table_arg_slot(MR_TrieNode *table_cur_ptr,
> > +	MR_Call_Table_Arg *call_table_arg_ptr)
> 
> Likewise here.

Done.

Zoltan.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list