[m-rev.] diff: conditionalize references to EINTR

Simon Taylor stayl at cs.mu.OZ.AU
Sun Nov 10 01:11:46 AEDT 2002


On 10-Nov-2002, Fergus Henderson <fjh at cs.mu.OZ.AU> wrote:
> On 10-Nov-2002, Simon Taylor <stayl at cs.mu.OZ.AU> wrote:
> > 
> > Only refer to EINTR if it is defined.
> > 
> > runtime/mercury_std.h:
> > 	Add a macro MR_is_eintr which tests whether its
> > 	argument is EINTR, or returns false if EINTR
> > 	not undefined.
> > 
> > trace/mercury_trace_internal.c:
> > compiler/process_util.m:
> > 	Use MR_is_eintr.
> 
> That looks good, thanks.
> 
> BTW it looks like your patch also included a bug fix which was
> not mentioned in the log message:

That didn't actually fix a bug, I just thought it was clearer and
less error-prone to initialize the variable where it was used.
(But yes, it should have gone in the log message).

Simon.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list