[m-rev.] for review: get tests/invalid working in the il grade

Peter Ross pro at missioncriticalit.com
Fri Nov 8 03:15:50 AEDT 2002


fjh wrote:
> On 07-Nov-2002, Peter Ross <pro at missioncriticalit.com> wrote:
> >

> In the long run we should add better support to getopt.m for
> determining whether an option has been explicitly or implicitly set/unset,
> and then have the IL and Java grades override the intermodule
> optimization setting only if "--no-intermodule-optimization" wasn't
> explicitly set.
>
Are you sure that this is such a great idea.  --intermodule-optimization is
needed to compile correctly in the java and il grades.  I don't think that
the user should be able to override this option.  I guess we could output a
warning if the user did this.

> But this is fine for now, modulo one suggestion below.

> > Index: compiler/options.m
> > @@ -3117,6 +3123,11 @@
> >  "\tOnly read the inter-module optimization information",
> >  "\tfor directly imported modules, not the transitive",
> >  "\tclosure of the imports.",
> > + /* Developer only option
> > + "--no-automatic-intermodule-optimization",
> > + "\tDon't automatically enable intermodule optimization for"
> > + "\tthose backends which require it.",
> > + */
>
> I suggest adding a comment "This is used in tests/invalid/Mercury.options"
> after "Developer only option".
>
Done.

--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list