[m-rev.] for review: configure.in improvements

[Simon Taylor]

On 08-Nov-2002, Fergus Henderson <fjh at cs.mu.OZ.AU> wrote:
> On 08-Nov-2002, Simon Taylor <stayl at cs.mu.OZ.AU> wrote:
> >  case $remake_dependencies in true)
> > -	mmake depend ;;
> > +	MERCURY_MSG("regenerating dependencies to enable GCC backend")
> > +	MERCURY_MSG("and/or disable Aditi backend.")
> > +
> > +	mmake depend >&AC_FD_CC 2>&1
> > +	if test $? != 0; then
> > +		exit $?
> > +	fi
> > +	;;
> 
> If `mmake depend' fails, then configure should return a non-zero exit
> status.  The code above will still exit with status zero, because the
> second $?  refers to the exit status of "test".
> 
> Also, if the messages from mmake depend are being redirected to config.log,
> as happens in the new code above, then if mmake depend fails we need to
> output a message, preferably one that mentions the "config.log" file.

Index: configure.in
===================================================================
RCS file: /home/mercury1/repository/mercury/configure.in,v
retrieving revision 1.337
diff -u -u -r1.337 configure.in
--- configure.in	7 Nov 2002 15:25:23 -0000	1.337
+++ configure.in	7 Nov 2002 15:57:34 -0000
@@ -3196,9 +3196,10 @@
 	MERCURY_MSG("regenerating dependencies to enable GCC backend")
 	MERCURY_MSG("and/or disable Aditi backend.")
 
-	mmake depend >&AC_FD_CC 2>&1
-	if test $? != 0; then
-		exit $?
+	mmake depend
+	status=$?
+	if test $status != 0; then
+		exit $status
 	fi
 	;;
 esac
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------