[m-rev.] for review: report error for install prefix containing spaces

Fergus Henderson fjh at cs.mu.OZ.AU
Thu May 9 19:28:17 AEST 2002


On 09-May-2002, Simon Taylor <stayl at cs.mu.OZ.AU> wrote:
> 
> +++ configure.in	8 May 2002 13:51:46 -0000
> @@ -53,6 +53,13 @@
>  else
>  	PREFIX="$prefix"
>  fi
> +case `echo $PREFIX | tr ' ' '@'` in
> +    *@*)

That will give a false hit if the path contains an "@".
It would be simpler and more correct to just write this as

	case "$PREFIX" in
	    *" "*)

or

	case "$PREFIX" in
	    *\ *)

Otherwise that looks fine.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
The University of Melbourne         |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list