[m-rev.] for review: java as foreign and target language

[Fergus Henderson]

That looks great.

I have just a few minor quibbles about the formatting of the log message,
and some pedantic suggestions about the error messages.

On 06-Mar-2002, Andre Yang <ayang at rationalizer.com> wrote:
> Estimated hours taken: 18
> 
> The java language is added to the foreign language family and to the target language family.

Please keep lines to no more than 80 columns in width.

> compiler/globals.m
> adds java support to the 'convert_foreign_language_2/2'

Change ".m" to ".m:", and indent the following line by one tab.
Change "adds" to "<tab>Adds", and add a full stop at the end.

Likewise for the log messages for all the other files.

> +++ mercury/compiler/mlds_to_ilasm.m	6 Mar 2002 16:01:52 -0000
> @@ -85,6 +85,8 @@
>  	sorry(this_file, "language C foreign code not supported").
>  handle_foreign_lang(il, _, _) :-
>  	sorry(this_file, "language IL foreign code not supported").
> +handle_foreign_lang(java, _, _) :-
> +	sorry(this_file, "language JAVA foreign code not supported").

s/JAVA/Java/

> +++ mercury/compiler/mercury_compile.m	6 Mar 2002 16:03:17 -0000
> @@ -3156,6 +3156,9 @@
>  	;
>  		{ Lang = il },
>  		{ error("sorry, not yet implemented: `:- pragma foreign_import_module' for IL") }
> +	;
> +		{ Lang = java },
> +		{ error("sorry, not yet implemented: `:- pragma foreign_import_module' for JAVA") }
>  	).

s/JAVA/Java/

Otherwise, that looks fine.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
The University of Melbourne         |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------