[m-rev.] for review: implement unify and compare for .NET in Mercury

Fergus Henderson fjh at cs.mu.OZ.AU
Mon Mar 11 23:33:33 AEDT 2002


On 20-Aug-2001, Tyson Dowd <trd at miscrit.be> wrote:
> 
> Implement generic unify and compare in (mostly) Mercury instead of MC++.
> 
> library/builtin.m:
> 	Call into rtti_implementation to implement unify and compare for
> 	the .NET backend.
...
> +++ library/builtin.m	20 Aug 2001 13:37:18 -0000
> @@ -428,87 +428,25 @@
...
> +:- interface.
> +:- pred call_rtti_generic_unify(T::in, T::in) is semidet.
> +:- pred call_rtti_generic_compare(comparison_result::out, T::in, T::in) is det.
> +:- implementation.
> +:- use_module rtti_implementation.

That should not be hidden in the middle of the module.
It should go at the end of the `interface' section.
And there should be some comments explaining what these predicates do.

But why did it need to be added at all?  Can't the code which needs it
just call rtti_implementation__generic_unify directly?

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
The University of Melbourne         |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list