[m-rev.] for review: mdb command line completion

[Fergus Henderson]

On 06-Mar-2002, Simon Taylor <stayl at cs.mu.OZ.AU> wrote:
> > > +#define MR_MAX_COMMAND_LEN 32
> > 
> > You should document
> > 	- what this is used for
> > 	- what the units are
> > 
> > Also, 32 is probably too small.
> 
> I've moved this #define to where it is used so that the
> meaning is obvious without documentation.

I still think 32 is too small.
The efficiency cost of making this e.g. 256 would be minimal.

> > > +static char *
> > > +MR_translate_double_underscores(char *start)
> > ...
> > > +	return start;
> > > +}
> > 
> > The return type for that should be `void *'.
> > 
> > (Whoever designed C's string handling routines has a lot to answer for ;-)
>
> Sorry, you'll have to explain that.

I meant to say `void', instead of `void *'.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
The University of Melbourne         |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------