[m-rev.] for review: make compiler use sub-modules

[Simon Taylor]

On 06-Mar-2002, Fergus Henderson <fjh at cs.mu.OZ.AU> wrote:
> Estimated hours taken: 60
> Branches: main
> 
> Use sub-modules to structure the modules in the Mercury compiler directory.
> 
> The main aim of this change is to make the overall, high-level structure
> of the compiler clearer, and to encourage better encapsulation of the
> major components.

Just a few minor issues:

Some lines are too long (I don't particularly care, but you raised this
issue in my MR_ prefix changes so I felt I should say something).

Simplification is HLDS transformation that emits warnings, not a warning
pass that transforms the HLDS (you've classified unused_args under
transform_hlds). common should probably be a sub-module of simplify.

I don't think smart recompilation belongs under hlds. Leaving it
as a separate component with recompilation.check, recompilation.usage
and recompilation.version as sub-modules of recompilation is probably
the best approach.

It would be nice to use a deeper hierarchy in places, for example
modecheck_call and modecheck_unify should be sub-modules of modes.
That can be a separate change.

Simon.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------