[m-rev.] for review: autoconfigure which version of .NET std lib to use

Fergus Henderson fjh at cs.mu.OZ.AU
Sun Mar 3 22:07:35 AEDT 2002


On 01-Mar-2002, Peter Ross <peter.ross at miscrit.be> wrote:
> +++ aclocal.m4
> +AC_MSG_CHECKING(for Microsoft.NET Visual C sharp)
> +AC_CACHE_VAL(mercury_cv_microsoft_visual_csharp, [
> +if test "$MS_CSC" != ""; then
> +	changequote(<<,>>) 
> +	MS_VISUALCSHARP_DIR=`expr "$MS_CSC" : '\(.*\)[/\\]*[bB]in[/\\]*csc`
> +	changequote([,]) 
> +	mercury_cv_microsoft_visual_csharp="yes"
> +else
> +	MS_VISUALCSHARP_DIR=""
> +	mercury_cv_microsoft_visual_csharp="no"
> +fi
> +])
> +AC_MSG_RESULT($mercury_cv_microsoft_visual_csharp)

The variables MS_VISUALCSHARP_DIR and mercury_cv_microsoft_visual_csharp
are not used.  So this code isn't needed.  I suggest you delete it.
Or alternatively, you should add some code which makes use of them...

>  # We default to the Beta 2 version of the library
>  mercury_cv_microsoft_dotnet_library_version=1.0.2411.0
>  if test $mercury_cv_microsoft_dotnet = "yes"; then

... e.g. maybe you want to test mercury_cv_microsoft_visual_csharp here,
instead of and/or in addition to $mercury_cv_microsoft_dotnet.

Otherwise, that change looks fine now.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
The University of Melbourne         |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list