[m-rev.] for review: MLDS back-end: generate closure layouts

[Fergus Henderson]

On 01-Mar-2002, Peter Ross <peter.ross at miscrit.be> wrote:
> > compiler/rtti_to_mlds.m:
> > 	Mark RTTI definitions as `final', and document why.
>
> I would add the rationale to why here, seeing that it is short.

OK, shall do.

> > Index: compiler/ml_unify_gen.m
...
> > +% XXX The following modules depend on the LLDS,
> > +% so ideally they should not be used here.
> > +:- import_module continuation_info. % needed for `generate_closure_layout'
> > +:- import_module stack_layout.      % needed for `represent_locn_as_int'
> > +:- import_module llds.       	    % needed for `layout_locn'
> 
> Is it possible to abstract these out?  It seems that we are getting more
> on more dependencies between the MLDS and LLDS as each day goes by.

I agree that abstracting these things out is a good idea, but doing it
well is not at all easy.  For example, the `layout_locn' type depends
on the LLDS `lval' type.  It really requires a fairly substantial redesign.

So I will leave the task of abstracting these things out for a separate change.

> > +++ compiler/stack_layout.m	27 Feb 2002 14:40:23 -0000
> > @@ -42,6 +42,8 @@
> > +:- pred stack_layout__represent_locn_as_int(layout_locn::in, int::out) is det.
> 
> Seeing that this predicate is now in the interface it should be
> documented what it does.

Shall do.  Thanks.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
The University of Melbourne         |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------