[m-rev.] for review: improvements for foreign_type

[Peter Ross]

Here is the review of make_hlds.m

On Fri, Jun 28, 2002 at 06:30:46PM +1000, Simon Taylor wrote:
> Index: compiler/make_hlds.m
> ===================================================================
> RCS file: /home/mercury1/repository/mercury/compiler/make_hlds.m,v
> retrieving revision 1.414
> diff -u -u -r1.414 make_hlds.m
> --- compiler/make_hlds.m	10 Jun 2002 15:58:05 -0000	1.414
> +++ compiler/make_hlds.m	26 Jun 2002 18:22:31 -0000
> @@ -2024,20 +2035,76 @@
>  		)
>  	).
>  
> +:- pred check_foreign_type_visibility(import_status::in,
> +		import_status::in) is semidet.
> +
> +check_foreign_type_visibility(OldStatus, NewStatus) :-
> +	( OldStatus = abstract_exported  ->
> +		status_is_exported_to_non_submodules(NewStatus, no)

Shouldn't that be a yes?  If the old status is abstract_exported then the
new status should also be exported.

> +	; OldStatus = exported ->
> +		NewStatus = exported
> +	;
> +		status_is_exported_to_non_submodules(OldStatus, no),
> +		status_is_exported_to_non_submodules(NewStatus, no)
> +	).	
> +
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------