[m-rev.] for review: new implementation of string__format in mercury.

[Fergus Henderson]

On 31-Jan-2002, p.incani <paulai at ugrad.unimelb.edu.au> wrote:
> Removed the old implementation of string__format because it relies on C's
> printf function - this causes problems when Mercury is compiled to Jave or
> .NET. Replaced it with a new version of string__format that works
> independently of C's printf, and which is written solely in Mercury.
>
> library/string.m:
> 	Removed old implementation of string__format.
> 	Slightly modified the format string parser.
> 	Replaced old string__format with a new Mercury implementation.
> 	Modified type 'specifier'.
> 	Added quite a few maths utilities that are needed to format
> 	floats.

Well, my first comment is that you should add some tests to the
test suite that test your new code.

For example, you should test printing int__minint and int__maxint.
Also there should be tests for all the formats, including the "%o"
and "%p" formats.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
The University of Melbourne         |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------