[m-rev.] for review: Modifications to the Java back-end

[Fergus Henderson]

On 23-Jan-2002, Michael Wybrow <mjwybrow at students.cs.mu.oz.au> wrote:
> 
> @@ -616,7 +642,7 @@
>  				OrigFuncSignature)
>  	),
>  	OrigFuncSignature = mlds__func_signature(OrigArgTypes, OrigRetTypes),
> -	Context = mlds__make_context(term__context("", 0)),
> +	Context = mlds__make_context(term__context_init),

There should be an XXX comment there.

> @@ -2420,8 +2241,10 @@
>  	;
>  		output_type(Type)
>  	),
> -	( { Type = mlds__func_type(_FuncParams);
> -	    Type =mlds__mercury_type(_Type, pred_type, _) } 
> +	(
> +		{ Type = mlds__func_type(_FuncParams)
> +		; Type = mlds__mercury_type(_Type, pred_type, _)
> +		} 

Maybe you missed or misunderstood my comment last time:
I think the test for `Type = mlds__func_type(_FuncParams)'
should be deleted here, since (a) the code here doesn't do the
right thing for that case and (b) that case should never occur anyway.

Thinking about it a bit more, really what you should be testing for is
whether or not the type is an array type.  Rather than mlds__func_type,
you should be checking for mlds__array_type.

But feel free to go ahead and commit this now;
you can address this point later.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
The University of Melbourne         |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------