[m-rev.] for review: minor changes for valuetype foreign_types

Fergus Henderson fjh at cs.mu.OZ.AU
Mon Jan 21 19:52:41 AEDT 2002


On 20-Jan-2002, Tyson Dowd <trd at cs.mu.OZ.AU> wrote:
> A few minor fixes promped by petdr's addition of support for value types
> for foreign_type.
...
> doc/reference_manual.texi:
> 	Improve the documentation wording for pragma foreign_type, and
> 	remove the XXX saying that we should accept value types, because
> 	we now accept value types.

It's not right to remove that XXX, since you've only fixed part of the
problem -- after petdr's change, user-defined value types are supported,
but builtin value types such as `int32' still aren't.

The documentation should explain this,
and there should still an XXX comment.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
The University of Melbourne         |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list