[m-rev.] for review: set runtime flags at compile time

Zoltan Somogyi zs at cs.mu.OZ.AU
Sat Jan 12 20:00:58 AEDT 2002


On 12-Jan-2002, Simon Taylor <stayl at cs.mu.OZ.AU> wrote:
>  		strcpy(dummy_command_line, cmd);
> -		strcat(dummy_command_line, options);
> +		/*
> +		** mkinit always puts a trailing space on MR_runtime_flags
> +		** if it is non-empty.
> +		*/
> +		strcat(dummy_command_line, MR_runtime_flags);
> +		strcat(dummy_command_line, env_options);

However, mkinit won't put a space at the *start* of MR_runtime_flags.
You should document that cmd also has a space at its end.

The rest of the diff is fine.

Zoltan.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list