[m-rev.] for review: atoms in the debugger

Zoltan Somogyi zs at cs.mu.OZ.AU
Wed Jan 2 15:29:06 AEDT 2002


On 02-Jan-2002, Ralph Becket <rafe at cs.mu.OZ.AU> wrote:
> > +:- func synthetic_term_to_doc(string, list(univ), bool)           = doc.
> > +:- func synthetic_term_to_doc(int, string, list(univ), bool)      = doc.
> 
> Is this function of sufficiently general utility to make it part of the
> interface to pprint?  Maybe it would be better off in a util module
> specific to the term browser?

That's what I initially tried to do. However, doing that would require
exporting the currently private function packed_cs_univ_args (and probably
packed_cs_to_depth, of which it is a version) from pprint.m. Is that OK
with you?

> > +            Doc = text(Functor) `<>` text("/") `<>` poly(i(Arity))
> > +        )
> 
> Minor point: the rest of pprint uses if-then-else rather than (_ -> _ ; _).

The code originally came from browse.m.

> I'm also slightly uncomfortable about combining a switch with the else
> clause - it might be clearer to put the switch in parentheses.

I have done so.

Zoltan.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list