[m-rev.] for review: reducing the size of type ctor info structures, part 1
Fergus Henderson
fjh at cs.mu.OZ.AU
Wed Jan 2 15:22:51 AEDT 2002
On 31-Dec-2001, Zoltan Somogyi <zs at cs.mu.OZ.AU> wrote:
> On 31-Dec-2001, Fergus Henderson <fjh at cs.mu.OZ.AU> wrote:
> > > +#define MR_type_ctor_rep(type_ctor_info) \
> > > + ((MR_TypeCtorRep) ((const struct MR_NewTypeCtorInfo_Struct *) \
> > > + (type_ctor_info))->MR_type_ctor_old_rep_CAST_ME)
> >
> > Please use MR_CHECK_EXPR_TYPE to check the type of the argument.
>
> I can't, because it is OK for the argument to have either of two types,
> MR_OldTypeCtorInfo_Struct and MR_NewTypeCtorInfo_Struct. In any case,
> all uses of the macro are currently type-safe, and once part 2 is installed,
> the macro will be deleted, its uses reverting to direct field references,
> only now referring to the repositioned field.
OK, that sounds like a good plan.
--
Fergus Henderson <fjh at cs.mu.oz.au> | "I have always known that the pursuit
The University of Melbourne | of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh> | -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-reviews mailing list
post: mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------
More information about the reviews
mailing list