[m-rev.] for review: grade java testing

[Fergus Henderson]

On 23-Feb-2002, Michael Wybrow <mjwybrow at students.cs.mu.oz.au> wrote:
> 
> For review by Fergus.
> 
> NOTE:  Even if there are no problems with this diff, I will still need to
> 	address the problem with building the java directory links (that
> 	Simon discovered last night) before I can commit this change.

Once the issues below are addressed, you can commit everything except the
changes to the test_mercury script which cause the java tests to actually be
invoked (on earth).

> tests/invalid/Mmakefile:
> tests/invalid/purity/Mmakefile:
...
> 	Disable test cases for grade java.

There should be no need to disable the test cases in the `tests/invalid'
or `tests/invalid/purity' directories for java.

> +++ tests/Mmake.common	22 Feb 2002 13:42:13 -0000
> @@ -34,9 +34,19 @@
>  # to print out the contents, because that precedes each line of output with
>  # the filename, which is helpful when running a parallel make.
>  #
> +ifneq "$(findstring java,$(GRADE))" ""
> +
> +%.out: %.class
> +	{ [ -f $*.inp ] && cat $*.inp; } | java `basename $< .class` > $@ 2>&1 \

Use "$*" rather than "`basename $< .class`".

Also don't hard-code the program name `java';
instead, add

	JAVA = java

and use "$(JAVA)" instead of "java".

Otherwise that looks fine.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
The University of Melbourne         |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------