[m-rev.] for review: extras/quickcheck comments

[Fergus Henderson]

On 22-Feb-2002, Peter Moulder <pmoulder at csse.monash.edu.au> wrote:
> The attached diff currently only adds comments and doesn't change any
> code.  The reviewer may suggest acting on some of these comments.
> 
> I won't write up a commit message until it's decided which of the
> comments should be acted on.  The current (comments-only) diff is
> fairly short.

> +++ qcheck.m	22 Feb 2002 04:08:23 -0000
> @@ -815,20 +815,54 @@
>  	% generate int
>  rand_int(BS0, BS) = Int :-
>  	Temp = rand_allint(BS0, BS1) rem 2,
> +	% effic: rnd(Temp, BS0, BS1), test Temp < 0.5.
> +	% (Or, for that matter, introduce a predicate that
> +	% avoids the float conversion.)

This comment is unclear -- I don't know what you mean here.

The rest of it looks fine.  And yes, all of the other comments
should ideally be acted on.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
The University of Melbourne         |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------