[m-rev.] for review: add MR_ prefixes
Simon Taylor
stayl at cs.mu.OZ.AU
Wed Feb 13 20:54:01 AEDT 2002
On 13-Feb-2002, Fergus Henderson <fjh at cs.mu.OZ.AU> wrote:
> Any particular reason why you didn't add MR_ prefixes to PIC and TAG_BITS?
That will be done as a separate change.
> > Index: runtime/mercury_goto.h
> ...
> > +#elif defined(MR_PIC_REG) && defined(MR_USE_GCC_GLOBAL_REGISTERS) && defined(__i386__)
> ...
> > +#elif defined(MR_PIC_REG) && defined(MR_USE_GCC_GLOBAL_REGISTERS) && defined(__i386__)
>
> Wrap these long lines (using \ at the end of the first line, of course).
>
> > Index: trace/mercury_trace_internal.c
> ...
> > +#if defined(MR_HAVE_OPEN) && defined(O_RDWR) && defined(MR_HAVE_FDOPEN) && \
> > + defined(MR_HAVE_CLOSE) && defined(MR_HAVE_DUP) && defined(MR_HAVE_DUP2) && \
>
> Wrap that one too.
Done.
> Otherwise that looks fine. But it might be wise to also try bootstrapping
> in grade hlc.gc with MR_NO_CONF_BACKWARDS_COMPAT before committing,
> as well as grade asm_fast.gc.
Done.
Simon.
Estimated hours taken: 2.5
Branches: main
Add MR_ prefixes to uses of configuration macros.
Bootcheck now succeeds with MR_NO_CONF_BACKWARDS_COMPAT.
Mmake.common.in:
Define MR_NO_CONF_BACKWARDS_COMPAT when checking
for namespace cleanliness.
RESERVED_MACRO_NAMES:
Remove the configuration macros.
runtime/mercury_conf_bootstrap.h:
Remove a duplicate definition of BOXED_FLOAT.
configure.in:
*/*.c:
*/*.h:
*/*.m:
Add MR_ prefixes.
--------------------------------------------------------------------------
mercury-reviews mailing list
post: mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------
More information about the reviews
mailing list