[m-rev.] for review: add MR_ prefixes to configuration macros

Fergus Henderson fjh at cs.mu.OZ.AU
Mon Feb 11 22:37:27 AEDT 2002


On 11-Feb-2002, Simon Taylor <stayl at cs.mu.OZ.AU> wrote:
> On 11-Feb-2002, Fergus Henderson <fjh at cs.mu.OZ.AU> wrote:
> > On 09-Feb-2002, Simon Taylor <stayl at cs.mu.OZ.AU> wrote:
> > > 
> > > Add MR_ prefixes to the configuration macros. This change only
> > > adds prefixes to the definitions of the macros, not the uses.
> > ...
> > > Index: configure.in
> > ...
> > > +mercury_check_for_functions () {
> 
> > According to the autoconf manual, "you should not use shell functions",
> > because they are not portable.  I'm not sure how important that is
> > these days, but I've used at least one shell which didn't support them.
> > We've also taken some effort to avoid using them in scripts/*.in.
> 
> configure.in already contains a shell function (check_c_files).
> When that was added, you wrote:
> 
>    However, I spent a bit of time investigating the issue.
>    The Posix shell standard includes support for shell functions.
>    They also work OK with all the main free software shells --  
>    bash, ash, and ksh. Apparently the platform whose
>    default shell doesn't support them is Ultrix.
> 
>    Portability to Ultrix is no longer very important.
>    And for Ultrix, we can always tell people to use bash
>    to run configure. So I think this is OK.

OK, in that case I agree with myself! ;-)

Your change is fine.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
The University of Melbourne         |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list