[m-rev.] diff: fix hlc link problem

Simon Taylor stayl at cs.mu.OZ.AU
Fri Feb 8 19:42:43 AEDT 2002


On 18-Jan-2002, Simon Taylor <stayl at cs.mu.OZ.AU> wrote:
> On 18-Jan-2002, Zoltan Somogyi <zs at cs.mu.OZ.AU> wrote:
> > On 18-Jan-2002, Simon Taylor <stayl at cs.mu.OZ.AU> wrote:
> > > Wouldn't it be better to make `MR_type_ctor_info_name' work properly
> > > with MR_HIGHLEVEL_CODE? Looking at runtime/mercury_type_info.h, it's
> > > supposed to.
> > 
> > I totally agree. However, I couldn't find any place that documents the naming
> > scheme being followed by the compiler for the TypeCtorInfos it generates in hlc
> > grades, so I decided to talk to Fergus, who is away this week, before trying
> > that approach. However, I wanted to fix the install problems immediately.
> > Hence the above change.
> 
> That's fine, but there should be an XXX comment in the code.

This review comment hasn't been addressed.

Simon.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list