[m-rev.] diff: clean up deconstruct and std_util

Fergus Henderson fjh at cs.mu.OZ.AU
Wed Dec 4 10:38:10 AEDT 2002


On 03-Dec-2002, Peter Ross <pro at missioncriticalit.com> wrote:
> 
> Index: library/deconstruct.m
> ===================================================================
> RCS file: /home/staff/zs/imp/mercury/library/deconstruct.m,v
> retrieving revision 1.19
> diff -u -r1.19 deconstruct.m
> --- library/deconstruct.m	3 Dec 2002 10:09:19 -0000	1.19
> +++ library/deconstruct.m	3 Dec 2002 10:40:44 -0000
> @@ -122,8 +122,6 @@
>  :- some [ArgT] pred arg(T, noncanon_handling, int, ArgT).
>  :- mode arg(in, in(do_not_allow), in, out) is semidet.
>  :- mode arg(in, in(canonicalize), in, out) is semidet.
> -:- mode arg(in, in(include_details_cc), in, out) is erroneous.
> -:- mode arg(in, in, in, out) is semidet.
...
> -:- mode det_arg(in, in, in, out) is det.
> +:- mode det_arg(in, in, in, out) is cc_multi.
...
> Index: library/std_util.m
...
> -:- pred argument_cc(T::in, int::in, univ::out) is cc_nondet.
> +:- pred argument_cc(T::in, int::in, maybe(univ)::out) is cc_multi.

These interface changes should be documented in the NEWS file.

Also, rather than deleting the `in' mode, it would IMHO be better to
replace it with an in(canonicalize_or_do_not_allow) mode,
where
	:- inst canonicalize_or_do_not_allow
		--->	canonicalize
		;	do_not_allow.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
The University of Melbourne         |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list