[m-rev.] for review: changes to the library from the mode-constraints branch

Zoltan Somogyi zs at cs.mu.OZ.AU
Mon Aug 19 17:36:19 AEST 2002


On 19-Aug-2002, Fergus Henderson <fjh at cs.mu.OZ.AU> wrote:
> We should not include robdd in the library unless/until this is fixed, IMHO.

OK, I'll do that.

> > +:- pragma foreign_proc("C",
> > +	one = (F::out),
> > +	[will_not_call_mercury, promise_pure],
> > +"
> > +	F = (MR_Word) trueVar();
> > +").
> 
> Does this compile with --high-level-data (grade hl.gc)?
> 
> It's OK if there are warnings, but please test that it still builds
> in grade hl.gc.

I will test it.

> > +% 	term__var_supply_max_var(VarSupply):
> > +%		returns the highest numbered variable returned from this
> > +%		var_supply.
> 
> What does "highest numbered" mean?
> 
> Is that the maximum in the ordering specified by compare/3,
> or the highest value returned by term__var_to_int?

The latter. I don't see how one could read the above text to mean the former.

> What's the purpose of providing this interface?

It provides information that the mode constraint system can use to batch up
some ROBDD operations, making them much more efficient.

I could put these predicates in the undocumented part of the interface,
if you like.

Zoltan.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list