[m-rev.] for review: MR_table_detfr_slot

Fergus Henderson fjh at cs.mu.OZ.AU
Mon Aug 19 15:52:46 AEST 2002


On 18-Aug-2002, Zoltan Somogyi <zs at cs.mu.OZ.AU> wrote:
> 
> In minimal model grades, add an extra slot to nondet stack frames containing
> the value of MR_sp when the stack frame is created. This will be necessary
> in future changes that manipulate stack segments.
...
> Index: mercury_stacks.h
...
> +/* convert a size in bytes to a size in words, rounding up if necessary */
> +#define MR_bytes_to_words(x) (((x) + sizeof(MR_Word) - 1) / sizeof(MR_Word))
> +

That fragment of the diff was not mentioned in the log message
and looks unnecessary.

Otherwise this is fine.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
The University of Melbourne         |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list