[m-rev.] for review: fix call_trace_getline

Simon Taylor stayl at cs.mu.OZ.AU
Wed Aug 14 01:30:41 AEST 2002


On 14-Aug-2002, Fergus Henderson <fjh at cs.mu.OZ.AU> wrote:
> Branches: main
> Estimated hours taken: 3
> 
> Fix a bug which broke tests/debugger/interactive_query in non-GC grades,
> e.g. asm_fast on murlibobo (dec-alpha-osf*).
> 
> browser/util.m:
> 	Fix a bug: call_trace_getline needs to be annotated with
> 	`will_not_call_mercury' instead of `may_call_mercury'.
> 	This is required because the code for it accesses MR_hp,
> 	which is only valid if `will_not_call_mercury' is specified.
> 
> 	The fix also required changing the return type from bool to int,
> 	so that it can return the right value without calling Mercury code.

Looks fine.

Simon.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list