[m-rev.] for review: more info in procedure body representations

[Mark Brown]

On 03-Apr-2002, Zoltan Somogyi <zs at cs.mu.OZ.AU> wrote:
> For review by Mark.
> 
> Add two pieces of information that will be needed to an upcoming change
> to the representation of procedure bodies in the declarative debugger.

This change is fine.  Go ahead and commit, after addressing the points
which follow.

Cheers,
Mark.

> Index: browser/program_representation.m
> ===================================================================
> RCS file: /home/mercury1/repository/mercury/browser/program_representation.m,v
> retrieving revision 1.6
> diff -u -b -r1.6 program_representation.m
> --- browser/program_representation.m	2001/12/19 06:44:47	1.6
> +++ browser/program_representation.m	2002/04/03 02:56:41
> @@ -150,6 +157,7 @@
>                          ;       first
>                          ;       later.
>  
> +	% Does a `some' goal change determinism?
>  :- type maybe_cut       --->    cut ; no_cut.

I don't understand this comment.

(After reading further down...) oh, I see.  I would re-phrase that comment
as "Does the goal 'some G' have a different determinism to G?".

> Index: compiler/prog_rep.m
> ===================================================================
> RCS file: /home/mercury1/repository/mercury/compiler/prog_rep.m,v
> retrieving revision 1.11
> diff -u -b -r1.11 prog_rep.m
> --- compiler/prog_rep.m	2002/03/28 03:43:34	1.11
> +++ compiler/prog_rep.m	2002/04/03 04:21:56
> @@ -36,6 +38,15 @@
>  			module_info :: module_info
>  		).
>  
> +:- pred prog_rep__represent_goal(hlds_goal::in, instmap::in, vartypes::in,
> +	module_info::in, goal_rep::out) is det.

The declaration should usually go just above the definition, unless it is
exported.  But in this case the five argument variant is no longer used,
I think, so it can be removed entirely.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------