[m-rev.] Change --dump-mlds to use the pretty printer

Fergus Henderson fjh at cs.mu.OZ.AU
Tue Oct 30 17:44:12 AEDT 2001


On 30-Oct-2001, Ralph Becket <rafe at cs.mu.OZ.AU> wrote:
> Estimated hours taken: 2
> Branches: main
> 
> Changed --dump-mlds option to use the pretty printer now that the performance
> bug in pprint has been solved.  Compiling the current largest file in the
> compiler directory, make_hlds.m at over 8000 lines, with `--dump-mlds all' now
> takes about an hour of wall time on a fast machine and generates six MLDS dump
> files each approximately 1M lines long.  Doing the same for mercury_compile.m,
> about half the size, takes only a minute.

Hmm, an hour of wall time is really a bit too long.  It sounds like there is
still an algorithmic problem of some kind remaining.

It might make sense to use different options for the different kinds of
MLDS dumps, since dumping the .c and .h dump files takes a lot less than
an hour, I'm sure.

But this change is already an improvement on the status quo, IMHO, so
please commit it if you haven't already.  Separating out the options
can be done lazily, i.e. when someone needs it...

P.S. The subject line should start with "for review:" or "diff:".

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  | "... it seems to me that 15 years of
The University of Melbourne         | email is plenty for one lifetime."
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- Prof. Donald E. Knuth
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list