[m-rev.] for review: source-linking for mdb

[Fergus Henderson]

On 29-Oct-2001, Mark Brown <dougl at cs.mu.OZ.AU> wrote:
> On 27-Oct-2001, Fergus Henderson <fjh at cs.mu.OZ.AU> wrote:
> > On 26-Oct-2001, Mark Brown <dougl at cs.mu.OZ.AU> wrote:
> > > New commands added to mdb are 'source_window', which
> > > opens a source-linked window if there is not one already open, and
> > > 'source_window_close' which shuts any open source window.
> > 
> > Those command names are long and ugly,
> > which is not good for interactive use.
> > Something more concise would be much better.
> > E.g. how about `edit' and `edit -c' (or `edit --close')?
> 
> I avoided that name for the reason David mentioned.  If the user edits
> the file, it will be out of sync with the executable and its line
> numbers.

OK, how about `view'?

> +++ trace/mercury_trace_internal.c
> @@ -1165,12 +1165,9 @@
>  		{
>  			; /* the usage message has already been printed */
>  		}
> -		else if (word_count != 1)
> -		{
> +		else if (word_count != 1) {
>  			MR_trace_usage("browsing", "source_window");

The `}' should be on the same line as `else'.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  | "... it seems to me that 15 years of
The University of Melbourne         | email is plenty for one lifetime."
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- Prof. Donald E. Knuth
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------