[m-rev.] for review: source-linking for mdb

[Mark Brown]

On 29-Oct-2001, Fergus Henderson <fjh at cs.mu.OZ.AU> wrote:
> On 29-Oct-2001, Mark Brown <dougl at cs.mu.OZ.AU> wrote:
> > On 29-Oct-2001, Zoltan Somogyi <zs at cs.mu.OZ.AU> wrote:
> > > On 26-Oct-2001, Mark Brown <dougl at cs.mu.OZ.AU> wrote:
> > > > +	/*
> > > > +	** Try running the server with '--version', and see if the
> > > > +	** output contains the string '+clientserver'.
> > > > +	**
> > > > +	** XXX if either server_cmd or fgrep is not found, the shell
> > > > +	** will print an error message that will end up on our terminal.
> > > > +	*/
> > > > +	sprintf(system_call, "%s --version 2>&1 | fgrep -q '+clientserver'",
> > > > +		server_cmd);
> > > 
> > > Any reason why you can't just add a "> /dev/null 2>&1" at the end of that
> > > command?
> > 
> > Done.
> 
> What was wrong with the shell printing an error message that will end up
> on our terminal?
> 
> If something goes wrong, the error message may well be helpful...

Yeah, you're probably right.  It just seemed a bit messy having somebody
else's error message printed.  I can undo that part in the relative diff
I just posted, if you like.

Alternatively, perhaps a neater way would be to allow a '-v' (or
'--verbose') option to the source window command, which prints out each
sh command before it is executed, and also prints out any error messages.
That way, the error messages would make more sense.  Would you prefer
this?

Cheers,
Mark.

--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------