[m-rev.] diff: remove destructive update modes of string__set_char

[Fergus Henderson]

On 26-Oct-2001, Simon Taylor <stayl at cs.mu.OZ.AU> wrote:
> On 26-Oct-2001, Simon Taylor <stayl at cs.mu.OZ.AU> wrote:
> > On 26-Oct-2001, Fergus Henderson <fjh at cs.mu.OZ.AU> wrote:
> > > On 26-Oct-2001, Simon Taylor <stayl at cs.mu.OZ.AU> wrote:
> > > > 
> > > > Estimated hours taken: 0.25
> > > > Branches: main, release
> > > > 
> > > > NEWS:
> > > > library/string.m:
> > > > 	Remove the buggy destructive update modes of string__set_char,
> > > > 	string__set_char_det and string__unsafe_set_char (they cause
> > > > 	crashes when applied to constant strings).
> > > 
> > > These modes are not buggy.  The bug is storing strings or other data
> > > structures in read-only memory when they are passed to procedures with
> > > mode `di'.
> > 
> > I'll change the NEWS file entry. The chances of this being fixed
> > properly any time soon aren't good.
> 
> I'll also restore the modes, but leave them commented out.
> This diff is relative to the revision before my previous change.

OK, that is much better.  Thanks.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  | "... it seems to me that 15 years of
The University of Melbourne         | email is plenty for one lifetime."
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- Prof. Donald E. Knuth
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------