[m-rev.] Updated diff for deep profiling.

[Zoltan Somogyi]

On 22-May-2001, Fergus Henderson <fjh at cs.mu.OZ.AU> wrote:
> > You are asking the wrong person. Tom wrote that, not me. However, I believe
> > he wrote it before Ralph wrote, or at least committed, bitmap.m.
> 
> If it's just historical reasons, then the code should be changed to use
> library/bitmap.m.

Maybe it should, but it won't be. I have better things to do than refactor
software I am not familiar with for such minor gain. Documenting clique.m
was hard enough.

I did add a comment to dense_bitset about library/bitmap.m.

> In that case, I suggest adding a comment e.g.
> 
> 	% <fill in the blank> should ensure that the pipe exists
> 	% (and is writable)
> 
> where <fill in the blank> identifies the relevant part of the system
> which is responsible for ensuring that the pipe exists.

It will be documented in the design document.

> I think it would be cleaner to undo it.
> It's a separate change, unrelated to adding deep profiling.
> Using backup file names such as foo.m.old works fine.

That makes filename completion somehat awkward, at least for me.

> > > The normal dependencies build all the .cs before building any of the .os.
> > 
> > That depends (depended) on RM_C.
> 
> Ah, so the normal rules failed only in the case when RM_C is set?

I don't think so. I had RM_C unset, and it failed for me.

> Since RM_C has been deleted, that case should no longer arise.
> Or is there some other case in which the normal rules failed?

I don't know. I deleted that dependency before I did a CVS update of the
changes removing RM_C.

> > However, I have made the reporting of array bound errors via exception
> > an implementor only facility, controlled by the ML_ARRAY_THROW_EXCEPTIONS.
> > Since implementors can manually make exception.h if required, I have deleted
> > the dependency of array.o on exception.c.
> 
> Deleting the dependency is the right thing to do, but I'd still like to
> know if there are any cases where manual intervention is required.

I don't know. I haven't needed that facility in a while.

Zoltan.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------