[m-rev.] for review: disable value numbering

[Simon Taylor]

On Fri, May 11, 2001 at 03:14:41PM +1000, Zoltan Somogyi wrote:
> Disable value numbering, now that it is no longer needed. The value numbering
> source files are not deleted from the CVS repository, since that would make
> their restoration (in the unlikely event that this is needed) inconvenient,
> but they will no longer be compiled or included in compiler executables.
> 
> doc/user_guide.texi:
> compiler/options.m:
> 	Delete the options dealing with value numbering.
> 
> compiler/optimize.m:
> 	Do not invoke value numbering.
> 
> compiler/handle_options.m:
> 	Delete code that handles implications involving value numbering.
> 	
> compiler/opt_debug.m:
> 	Delete code for debugging value numbering, since leaving it in
> 	would require importing value numbering modules and would thus drag
> 	them into the compiler executable.

Some of the test Mmakefiles refer to the options you have removed
(general/accumulator and hard_coded).

> Index: compiler/optimize.m
> ===================================================================
> @@ -58,23 +56,10 @@
>  	;
>  		set__init(LayoutLabelSet)
>  	},
> -	( { ValueNumber = yes } ->
> -		{ NovnRepeat is AllRepeat - VnRepeat },
> -		optimize__repeat(NovnRepeat, no, ContainsReconstruction,
> -			LayoutLabelSet, Instrs0, ProcLabel, C0, C1,
> +	optimize__repeat(Repeat, LayoutLabelSet, Instrs0, ProcLabel, C0, C1,
>  			OptDebugInfo0, OptDebugInfo1, Instrs1),
> -		optimize__middle(Instrs1, no, LayoutLabelSet, ProcLabel,
> -			C1, C2, OptDebugInfo1, OptDebugInfo2, Instrs2),
> -		optimize__repeat(VnRepeat, yes, ContainsReconstruction,
> -			LayoutLabelSet, Instrs2, ProcLabel, C2, C,
> -			OptDebugInfo2, OptDebugInfo, Instrs3)
> -	;
> -		optimize__repeat(AllRepeat, no, ContainsReconstruction,
> -			LayoutLabelSet, Instrs0, ProcLabel, C0, C1,
> -			OptDebugInfo0, OptDebugInfo1, Instrs1),
>  		optimize__middle(Instrs1, yes, LayoutLabelSet, ProcLabel,
> -			C1, C, OptDebugInfo1, OptDebugInfo, Instrs3)
> -	),
> +		C1, C, OptDebugInfo1, OptDebugInfo, Instrs3),
>  	optimize__last(Instrs3, LayoutLabelSet, C, OptDebugInfo, Instrs),
>  	{ CProc = c_procedure(Name, Arity, PredProcId, Instrs,
>  		ProcLabel, C, ContainsReconstruction) }.

Formatting error at optimize__middle.

Otherwise this change looks fine.

Simon.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------