[m-rev.] for review: fix for problem with debugger contexts

[Fergus Henderson]

On 07-May-2001, Zoltan Somogyi <zs at cs.mu.OZ.AU> wrote:
> On 07-May-2001, Fergus Henderson <fjh at cs.mu.OZ.AU> wrote:
> > --- compiler/handle_options.m	2001/05/02 11:36:35	1.107
> > +++ compiler/handle_options.m	2001/05/07 04:03:24
> > @@ -530,6 +530,13 @@
> >  	option_implies(procid_stack_layout, basic_stack_layout, bool(yes)),
> >  	option_implies(agc_stack_layout, basic_stack_layout, bool(yes)),
> >  
> > +	% dupelim.m doesn't preserve label layout structures
> > +	% (e.g. it can change the return address in a call
> > +	% to a different label whose code is the same but
> > +	% which has a different label layout structure),
> > +	% so we need to disable it when tracing.
> > +	option_implies(procid_stack_layout, optimize_dups, bool(no)),
> 
> The code diff is fine. However, the comment is misleading. procid_stack_layout
> can be switched on by accurate gc as well as debugging,

I don't think that is correct.  `--gc accurate' switches on agc_stack_layout,
which implies basic_stack_layout, but as far as I can tell from examining the
code in options.m and handle_options.m, it doesn't imply procid_stack_layout.

proc_id_stack_layout is only implied by profile_deep,
stack_trace (set by the debug grades), and trace_stack_layout
(set by the --trace options).

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
                                    |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------