[m-rev.] for review: support IL grades in mercury/*/Mmakefile better

Fergus Henderson fjh at cs.mu.OZ.AU
Tue Mar 13 19:56:01 AEDT 2001


On 13-Mar-2001, Tyson Dowd <trd at cs.mu.OZ.AU> wrote:
> boehm_gc/Mmakefile:
> browser/Mmakefile:
> trace/Mmakefile:
> 	Modify Mmakefiles so that we don't try to build unnecessary
> 	subsystems in IL grades.

The log message doesn't match the change: s/build/install/

Note that currently the compiler uses some of the stuff in the browser
directory, in particular browser/program_representation.m, even if tracing
isn't enabled.  So you still need to build the browser in order to
bootstrap the compiler.  (Of course bootstrapping the compiler is
a fair way off...)

> +ifneq (,$(findstring il,$(GRADE)))

I think it would be clearer to write that as
	ifeq ($(findstring il,$(GRADE)),il)
or
	ifneq ("$(findstring il,$(GRADE))","")

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
                                    |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list