[m-rev.] for review: use limited_deconstruct in sized_pretty.m

Mark Brown dougl at cs.mu.OZ.AU
Tue Jun 26 15:17:10 AEST 2001


Thanks.  I'll do both of these things in a separate change, and commit
this change now.

Cheers,
Mark.

On 26-Jun-2001, Zoltan Somogyi <zs at cs.mu.OZ.AU> wrote:
> On 26-Jun-2001, Mark Brown <dougl at cs.mu.OZ.AU> wrote:
> > Make mdb's term browser use limited_deconstruct/5 instead of deconstruct/4,
> > to avoid performance problems with large arrays.
> 
> That diff is fine. I have only two suggestions.
> 
> > +		measured_split(Univ, Params, Limit, Arity, yes, FunctorSize, 
> > +						Flag, NewLimit, NewParams),
> > +		( (Arity \= 0, Flag = no) ->
> > +			Exact0 = no
> > +		;
> > +			Exact0 = yes
> > +		),
> 
> The first is that you change Flag to something meaningful.
> 
> >  %------------------------------------------------------------------------------%
> 
> The second is that you shorten the lines of dashes everywhere in that file
> to our standard length, which can be diff'ed without spilling over.
> 
> Zoltan.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list