[m-rev.] for review: smart recompilation

Fergus Henderson fjh at cs.mu.OZ.AU
Sat Jun 23 11:55:52 AEST 2001


On 28-May-2001, Simon Taylor <stayl at cs.mu.OZ.AU> wrote:
> 
> compiler/recompilation.m:
> 	Type declarations for smart recompilation.
> 	Predicates to record program items used by compilation.
...
> Index: compiler/recompilation.m
> +% File: recompilation.m
> +% Main author: stayl
> +%
> +% Smart recompilation.
> +%
> +% Currently smart recompilation does not work properly with
> +% inter-module optimization. If a `.opt' file changes, all modules
> +% importing it need to be recompiled.
> +%
> +% A module must be recompiled if
> +% - The file itself has changed.
> +% - An imported item used in compiling the module has changed or been removed.
> +% - An item has been added to an imported module which could cause an
> +%   ambiguity with an item used in compiling the module.

I suggest you swap the order of the two paragraphs above.

Also, there should be some comments explaining what this module is for,
e.g. as you have in the cvs log message.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
The University of Melbourne         |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list