[m-rev.] for review: arrays and the debugger

[Mark Brown]

On 15-Jun-2001, Zoltan Somogyi <zs at cs.mu.OZ.AU> wrote:
> Index: runtime/mercury_ml_expand_body.h
> ===================================================================
> RCS file: mercury_ml_expand_body.h
> diff -N mercury_ml_expand_body.h
> --- /dev/null	Fri Dec  1 02:25:58 2000
> +++ mercury_ml_expand_body.h	Wed Jun 13 02:44:41 2001
> @@ -0,0 +1,671 @@
> +/*
> +** Copyright (C) 2001 The University of Melbourne.
> +** This file may only be copied under the terms of the GNU Library General
> +** Public License - see the file COPYING.LIB in the Mercury distribution.
> +*/
> +
> +/*
> +** mercury_ml_expand_body.h
> +**
> +** This file is included several times in library/std_util.m. Each inclusion
> +** defines a function that the body of several variants of the old ML_expand
> +** function, which, given a data word and its type_info, returned its functor,
> +** arity, argument vector and a type_info vector describing its arguments.

That sentence doesn't make sense.

> +** One variants still does all that. The others perform different subsets of

s/variants/variant/

> +** this task. The reason for having those specialized variants is that
> +** executing the full task can be extremely time consuming, especially when
> +** large arrays are involved. (Simply allocating and filling in an array of
> +** a million typeinfos can cause a system to start paging.) Therefore we try to
> +** make sure that in every circumstance we perform the minimum work possible.

It would be better if you mentioned the circumstances in question (that is,
mention each of the callers of these functions).

I've now completed the review.  I'm happy for you to commit this change
after you have addressed my review comments, provided that Fergus can be
convinced that this is an acceptable approach.

Cheers,
Mark.

--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------