[m-rev.] for review: change order of fields of time__tm

Fergus Henderson fjh at cs.mu.OZ.AU
Fri Jun 1 03:02:04 AEST 2001


On 01-Jun-2001, Simon Taylor <stayl at cs.mu.OZ.AU> wrote:
> 
> Estimated hours taken: 1
> Branches: main, release
> 
> library/time.m:
> 	Change the order of the fields of type `time__tm' so that
> 	comparison of values of type `tm' whose `tm_dst' fields are identical
> 	is equivalent to comparison of the times those values represent.

That looks good, thanks.  Just one small suggestion:

> +++ library/time.m	2001/05/31 16:38:51
> @@ -39,17 +39,20 @@
>  
>  	% The `tm' type is a concrete type that represents calendar
>  	% times, broken down into their constituent components.
> +	% Comparison of `tm' values whose `tm_dst' components are
> +	% identical is equivalent to comparison of the times those
> +	% `tm' values represent.

It would help to make it explicit what kind of comparison you mean:
s/Comparison/Comparison (via compare/3)/

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
                                    |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list