[m-rev.] for review: hlds_goal field names

[Fergus Henderson]

On 23-Jul-2001, Zoltan Somogyi <zs at cs.mu.OZ.AU> wrote:
> compiler/hlds_goal.m:
> 	Add field names to several of the types defined in this file.

That looks fine.

I have a couple of suggestions about the field names chosen.

> @@ -137,7 +153,11 @@
>  		% closures for the builtin aditi update predicates -
>  		% they should be kept close to the update call where
>  		% possible to make it easier to use indexes for the update.
> -	;	{ some(list(prog_var), can_remove, hlds_goal) }
> +	;	{ some(
> +			some_exist	:: list(prog_var),

I think "some_exist_vars" would be a better name.
(or perhaps "some_quantified_vars", "some_quant_vars",
or "some_existq_vars").

>  	;	if_then_else(
> -			list(prog_var),	% The locally existentially quantified
> +			ite_exist	:: list(prog_var),
> +					% The locally existentially quantified
>  					% variables <Vars>.

Likewise here.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
The University of Melbourne         |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------