[m-rev.] for review: IL backend: improve mmake support

Fergus Henderson fjh at cs.mu.OZ.AU
Mon Jul 23 00:28:40 AEST 2001


On 17-Jul-2001, Peter Ross <peter.ross at miscrit.be> wrote:
> On Tue, Jul 17, 2001 at 02:31:48AM +1000, Fergus Henderson wrote:
> > The `.dep' Makefile fragment generated there uses GNU Make extensions,
> > which will break --no-assume-gmake.
> > 
> > Possible solutions:
> > 
> > 	(a) test for `Target = il' in compiler/modules.m,
> > 	    rather than inserting the test in the generated .dep file.
> > 
> > 	(b) do as you currently do, unless --no-assume-gmake is passed,
> > 	    in which case do (a)
> > 
> > 	(c) drop support for the --no-assume-gmake option.
> > 
> > My preference is for (a) or (b).
> 
> diff -u compiler/modules.m compiler/modules.m

> [implementing (b)]

That looks fine.

But please test it with --no-assume-gmake before committing it,
in case you haven't already.

Cheers,
	Fergus.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
The University of Melbourne         |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list