[m-rev.] Re: for review: install the ILC grade

Tyson Dowd trd at cs.mu.OZ.AU
Wed Jul 18 07:00:42 AEST 2001


On 17-Jul-2001, Peter Ross <peter.ross at miscrit.be> wrote:
> Hi,
> 
> Here it is.
> 
> 
> ===================================================================
> 
> 
> Estimated hours taken: 2.5
> Branches: main
> 
> Fix mmake rules to install the ilc grade.
> 
> Mmakefile:
>     Run the install command in the runtime directory so that the
>     install_header command is run for the ilc target.

s/target/grade

This log message is a bit misleading.  You should mention that this
change is to the install_grades target in the top-level Mmakefile.

Actually, I think this is the wrong thing to do anyway as you will be 
running the install target on every grade, which will copy the header
files many times for no good reason (and once when it is useful).

How about you just change the install_lib target for the IL backend
(there is conditional code there to handle it) so it depends on
install_headers?

> Index: scripts/Mmake.vars.in
> ===================================================================
> RCS file: /home/mercury1/repository/mercury/scripts/Mmake.vars.in,v
> retrieving revision 1.50
> diff -u -r1.50 Mmake.vars.in
> --- scripts/Mmake.vars.in	17 Jul 2001 08:56:32 -0000	1.50
> +++ scripts/Mmake.vars.in	17 Jul 2001 16:34:12 -0000
> @@ -159,7 +159,7 @@
>  # The system libraries were once needed here, but are currently unnecessary.
>  MS_CL_LIBS	= 
>  MERC_C_INCL_DIR = @LIBDIR@/inc
> -MERC_DLL_DIR    = @LIBDIR@/inc
> +MERC_DLL_DIR    = @LIBDIR@/lib/ilc/@FULLARCH@

Hmmm... this might work for the moment, but when I install with grade
set to "il" I don't want to install into the ilc directory.

Apart from this the diff looks ok.

Tyson.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list