[m-rev.] for review: IL backend: improve mmake support
Fergus Henderson
fjh at cs.mu.OZ.AU
Tue Jul 17 02:31:48 AEST 2001
On 16-Jul-2001, Peter Ross <peter.ross at miscrit.be> wrote:
> Improve the mmake support for the IL backend.
That looks good, thanks.
This things that you've fixed had been bugging me.
There's just one problem:
> Index: compiler/modules.m
...
> @@ -3269,13 +3275,18 @@
>
> module_name_to_file_name(SourceModuleName, "", no, ExeFileName),
> io__write_strings(DepStream, [
> + "ifeq ($(findstring il,$(GRADE)),il)\n",
> + ExeFileName, " : ", ExeFileName, ".exe ",
> + "$(", MakeVarName, ".dlls)\n",
> + "else\n",
> ExeFileName, " : $(", MakeVarName, ".cs_or_ss) ",
> "$(", MakeVarName, ".os) ",
> InitObjFileName, " $(MLOBJS) ", All_MLLibsDepString,
> "\n",
> "\t$(ML) $(ALL_GRADEFLAGS) $(ALL_MLFLAGS) -o ",
> ExeFileName, " ", InitObjFileName, " \\\n",
> - "\t $(", MakeVarName, ".os) $(MLOBJS) $(ALL_MLLIBS)\n\n"
> + "\t $(", MakeVarName, ".os) $(MLOBJS) $(ALL_MLLIBS)\n",
> + "endif\n\n"
The `.dep' Makefile fragment generated there uses GNU Make extensions,
which will break --no-assume-gmake.
Possible solutions:
(a) test for `Target = il' in compiler/modules.m,
rather than inserting the test in the generated .dep file.
(b) do as you currently do, unless --no-assume-gmake is passed,
in which case do (a)
(c) drop support for the --no-assume-gmake option.
My preference is for (a) or (b).
--
Fergus Henderson <fjh at cs.mu.oz.au> | "I have always known that the pursuit
The University of Melbourne | of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh> | -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-reviews mailing list
post: mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------
More information about the reviews
mailing list