[m-rev.] diff: IL back-end: improve commit handling
Tyson Dowd
trd at cs.mu.OZ.AU
Mon Jul 16 19:20:56 AEST 2001
On 16-Jul-2001, Fergus Henderson <fjh at cs.mu.OZ.AU> wrote:
> On 16-Jul-2001, Tyson Dowd <trd at cs.mu.OZ.AU> wrote:
> > On 14-Jul-2001, Fergus Henderson <fjh at cs.mu.OZ.AU> wrote:
> > > On 13-Jul-2001, Tyson Dowd <trd at cs.mu.OZ.AU> wrote:
> > > > Doesn't this code leave an unused variable lying around (the commit
> > > > variable in the environment)?
> > >
> > > Yes. I was planning to leave that one for another day...
> >
> > The code I wrote that you backed out of CVS recently fixed this, but was
> > getting an error with unknown types on ops.m. Perhaps in conjunction
> > with the change you just posted which fixes some of the unknown types
> > being generated, this will work now?
>
> Possibly, but the change of yours that I backed out was to code which my next
> change abolished anyway. It couldn't just be re-added.
>
> I don't think ml_code_gen.m is the right place to fix it anyway.
> The right place to fix it is in mlds_to_il.m.
I don't think it is a good idea to introduce variables in ml_code_gen.m
that are only used by specific backends, and then go to all the trouble
of weeding them out in the other backends. But if you want to...
--
Tyson Dowd #
# Surreal humour isn't everyone's cup of fur.
trd at cs.mu.oz.au #
http://www.cs.mu.oz.au/~trd #
--------------------------------------------------------------------------
mercury-reviews mailing list
post: mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------
More information about the reviews
mailing list