[m-rev.] for review: make deconstruct work for herbrand variables

[Fergus Henderson]

On 11-Jul-2001, David Jeffery <dgj at cs.mu.OZ.AU> wrote:
> 
> I have added the following comment:
> 
>                                 /*
>                                 ** XXX We should do something like the
>                                 ** following, since deconstructing a value
>                                 ** that might be a variable should be
>                                 ** cc_multi rather than det. However, there
>                                 ** is no such version of deconstruct yet,
>                                 ** so we'll leave it out.
>                                 */
>                         /*expand_info->non_canonical_type = TRUE;*/

Great, thanks.

> > The "return;" statement there, buried in the middle of a very long function,
> > is asking for trouble.
> 
> You are right, but in this case I thought it was less of an evil than trying
> to escape gracefully from the nested switch.

OK.

This change is fine.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
The University of Melbourne         |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------