[m-rev.] for review: nested classes

Tyson Dowd trd at cs.mu.OZ.AU
Wed Jul 11 06:17:21 AEST 2001


On 10-Jul-2001, Peter Ross <peter.ross at miscrit.be> wrote:
> Hi,
> 
> For Tyson to review.
> 
> 
> ===================================================================
> 
> 
> Estimated hours taken: 4
> Branches: main
> 
> Implement nested classes.
> 
> compiler/ilasm.m:
>     Update the classattr type to the latest fields from the SDK
>     documentation.
>     Add the predicate output_classattr which will write the string
>     representation of the attribute.
> 
> compiler/mlds_to_il.m:
>     Factor out the code between classes and nested classes.
>     Generate the ILDS for nested classes.

> -	ClassName = class_name(Info1 ^ module_name, EntityName),
> -	list__map_foldl(generate_method(ClassName, no), Members,
> -			MethodsAndFields, Info1, Info2),
> -	list__map_foldl(generate_method(ClassName, yes(Parent)), Ctors,
> -			IlCtors, Info2, Info3),
> -	MethodsAndFieldsAndCtors = IlCtors ++ MethodsAndFields,
> +	generate_class_body(Name, ClassDefn, ClassName, EntityName, Extends,
> +			Interfaces, MethodsAndFieldsAndCtors, Info1, Info3),

Probably better to renumber the Infos to inlcude Info2, or I am going to
be looking for it when I edit this code.

Apart from this, the change looks fine, thanks.

Tyson.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list