[m-rev.] for review: line numbers for collect.

[Fergus Henderson]

On 03-Jul-2001, Erwan Jahier <Erwan.Jahier at irisa.fr> wrote:
> Make line numbers available for collect.

Delete the control-S from the log message ;-)

> Index: trace/mercury_trace_external.c
...
> +/*
> +** This function retrieves the line number of the current goal.
> +*/
> +int
> +MR_get_line_number(MR_Word *saved_regs, const MR_Label_Layout *layout, 
> +	MR_Trace_Port port)
> +{
> +	if ( port == MR_PORT_CALL || port == MR_PORT_EXIT || 
> +	     port == MR_PORT_REDO || port == MR_PORT_FAIL ) 
> +	/* 
> +	** At external events, we want the line number 
> +	** where the call is made, not the one where the 
> +	** procedure is defined.
> +	*/

What about MR_PORT_EXCEPTION?

Should you be using MR_port_is_interface() here?

(I know you only moved that code around in this change...
I should have pointed that out earlier.)


Apart from that, this change looks fine.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
The University of Melbourne         |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------