[m-rev.] trivial diff: disable `--optimize-duplicate-calls'

Simon Taylor stayl at cs.mu.OZ.AU
Fri Dec 14 12:29:48 AEDT 2001


Estimated hours taken: 0.1
Branches: main

compiler/options.m:
	Don't enable `--optimize-duplicate-calls' at any optimization level.
	It breaks solutions/2 due to bugs in the handling of impurity.

Index: options.m
===================================================================
RCS file: /home/mercury1/repository/mercury/compiler/options.m,v
retrieving revision 1.348
diff -u -u -r1.348 options.m
--- options.m	12 Dec 2001 04:33:45 -0000	1.348
+++ options.m	14 Dec 2001 01:26:47 -0000
@@ -819,11 +819,7 @@
 		% it affects the semantics
 	constraint_propagation	-	bool(no),
 	local_constraint_propagation	-	bool(no),
-% XXX optimize_duplicate_calls is broken -- it ignores impurity.
-% It currently screws up builtin_aggregate, which leads to failures
-% of most test cases using solutions/2 (e.g. general/commit_bug)
-% in grade asm_fast. It should be reenabled when we have fixed that bug.
-%	optimize_duplicate_calls -	bool(no),
+	optimize_duplicate_calls -	bool(no),
 	constant_propagation	-	bool(no),
 	excess_assign		-	bool(no),
 	optimize_saved_vars	-	bool(no),
@@ -1736,7 +1732,11 @@
 	common_struct		-	bool(yes),
 	user_guided_type_specialization
 				-	bool(yes),
-	optimize_duplicate_calls -	bool(yes),
+% XXX optimize_duplicate_calls is broken -- it ignores impurity.
+% It currently screws up builtin_aggregate, which leads to failures
+% of most test cases using solutions/2 (e.g. general/commit_bug)
+% in grade asm_fast. It should be reenabled when we have fixed that bug.
+%	optimize_duplicate_calls -	bool(yes),
 	simple_neg		-	bool(yes),
 
 	optimize_rl		-	bool(yes),
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list